lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: apm: xgene: force XGene enet driver to re-balance IRQ usage
From
Date
On 09/18/2018 05:09 PM, Lendacky, Thomas wrote:
>
>
> On 09/17/2018 09:35 PM, David Miller wrote:
>> From: Al Stone <ahs3@redhat.com>
>> Date: Mon, 17 Sep 2018 17:35:33 -0600
>>
>>> @@ -866,8 +866,11 @@ static int xgene_enet_napi(struct napi_struct *napi, const int budget)
>>> processed = xgene_enet_process_ring(ring, budget);
>>>
>>> if (processed != budget) {
>>> + struct irq_desc *desc = irq_to_desc(ring->irq);
>>> +
>>> napi_complete_done(napi, processed);
>
> The problem could be that the driver isn't checking the
> napi_complete_done() return code. It was changed to return a bool and
> the check should be more like:
>
> if ((processed != budget) && napi_complete_done(napi, processed)) {
>
> If it returns false, then the driver will get called for polling again
> after having issued enable_irq() and it well then issue the enable_irq()
> a second (or more) time without having the matching diable_irq().
>
> Thanks,
> Tom

Aha, that might be. My apologies -- I play in ACPI but seldom in the network
drivers, so was not fully aware of that change. I can give that a try.

Thanks for the pointer.

--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@redhat.com
-----------------------------------

\
 
 \ /
  Last update: 2018-09-19 01:15    [W:1.973 / U:2.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site