lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [REVIEW][PATCH 02/20] signal/x86: Inline fill_sigtrap_info in it's only caller send_sigtrap
> 
> clear_siginfo(&info);
> - fill_sigtrap_info(tsk, regs, error_code, si_code, &info);
> + tsk->thread.trap_nr = X86_TRAP_DB;
> + tsk->thread.error_code = error_code;
> +
> + info.si_signo = SIGTRAP;
> + info.si_code = si_code;
> + info.si_addr = user_mode(regs) ? (void __user *)regs->ip : NULL;

clear_siginfo already zeroes the whole structure, so this could be
written more clearly as:

if (user_mode(regs)
info.si_addr = (void __user *)regs->ip;

\
 
 \ /
  Last update: 2018-09-19 07:48    [W:0.231 / U:8.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site