lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: erofs: Fix a unused variable 'arg' warning
From
Date
On 09/19/2018 10:16 AM, zhong jiang wrote:
> I find the following warning when compiling the kernel.
>
> drivers/staging/erofs/super.c:195:6: warning: unused variable 'arg' [-Wunused-variable]
> int arg = 0;
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/staging/erofs/super.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c
> index 6423592..c04313f 100644
> --- a/drivers/staging/erofs/super.c
> +++ b/drivers/staging/erofs/super.c
> @@ -192,7 +192,9 @@ static int parse_options(struct super_block *sb, char *options)
> {
> substring_t args[MAX_OPT_ARGS];
> char *p;
> +#ifdef CONFIG_EROFS_FAULT_INJECTION
> int arg = 0;
> +#endif
>
> if (!options)
> return 0;

Hi,

The fix has already included in my patch series "staging: erofs: option
validation for remount and some code cleanups",
so it will be fixed when the series merge into tree and we do not
encourage surrounding the code with macro in option
parsing for this case.

Thanks,
Chengguang

\
 
 \ /
  Last update: 2018-09-19 05:08    [W:0.038 / U:2.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site