lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 1/1] kbuild: Optimize tests and remove shadowed local variable.
Removes an unnecessary shadowed local variable (start).
Optimize test of isdigit:
- If isalpha returns true, isdigit will return false, so no need to test.

Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
---
scripts/asn1_compiler.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c
index c146020fc783..a0056df4e358 100644
--- a/scripts/asn1_compiler.c
+++ b/scripts/asn1_compiler.c
@@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)

/* Handle string tokens */
if (isalpha(*p)) {
- const char **dir, *start = p;
+ const char **dir;

/* Can be a directive, type name or element
* name. Find the end of the name.
@@ -454,10 +454,10 @@ static void tokenise(char *buffer, char *end)

tokens[tix++].token_type = TOKEN_TYPE_NAME;
continue;
- }

- /* Handle numbers */
- if (isdigit(*p)) {
+ } else if (isdigit(*p)) {
+ /* Handle numbers */
+
/* Find the end of the number */
q = p + 1;
while (q < nl && (isdigit(*q)))
--
2.19.0
\
 
 \ /
  Last update: 2018-09-19 01:00    [W:0.084 / U:13.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site