lkml.org 
[lkml]   [2018]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] tty_port: Fix function name and brief desc
On Wed, Sep 12, 2018 at 05:50:43PM +1000, Tobin C. Harding wrote:
> @@ -235,7 +235,7 @@ void tty_port_free_xmit_buf(struct tty_port *port)
> EXPORT_SYMBOL(tty_port_free_xmit_buf);
>
> /**
> - * tty_port_destroy -- destroy inited port
> + * tty_port_destroy() - Destroy inited port.

Ok, using () for a function name, that's fine, but then you do:

> /**
> - * tty_port_tty_set - set the tty of a port
> - * @port: tty port
> - * @tty: the tty
> + * tty_port_tty_set - Set the tty of a port.

Oops, not here. Consistency is the key.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-09-18 15:38    [W:0.109 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site