lkml.org 
[lkml]   [2018]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [RFC PATCH v2 3/3] nvmem: zynqmp: Added zynqmp nvmem firmware driver
Date
Hi Srinivas,

Thansks for providing the comments..
Please find my repsonce inline...

> -----Original Message-----
> From: Srinivas Kandagatla [mailto:srinivas.kandagatla@linaro.org]
> Sent: Sunday, September 16, 2018 7:41 PM
> To: Nava kishore Manne <navam@xilinx.com>; robh+dt@kernel.org;
> mark.rutland@arm.com; Michal Simek <michals@xilinx.com>; Rajan Vaja
> <RAJANV@xilinx.com>; Jolly Shah <JOLLYS@xilinx.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [RFC PATCH v2 3/3] nvmem: zynqmp: Added zynqmp nvmem
> firmware driver
>
> Few minor Nits...
>
> I remember asking about this in the last review!
>
> On 04/09/18 10:52, Nava kishore Manne wrote:
> > This patch adds zynqmp nvmem firmware driver to access the SoC
> > revision information from the hardware register.
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > ---
> > diff --git a/drivers/nvmem/zynqmp_nvmem.c
> > b/drivers/nvmem/zynqmp_nvmem.c new file mode 100644 index
> > 0000000..e377900
> > --- /dev/null
> > +++ b/drivers/nvmem/zynqmp_nvmem.c
> > @@ -0,0 +1,84 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2018 Xilinx, Inc.
> > + */
> > +
> > +#include <linux/module.h>
> > +#include <linux/nvmem-provider.h>
> > +#include <linux/of.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/firmware/xlnx-zynqmp.h>
> > +
> > +#define SILICON_REVISION_MASK 0xF
> > +
> > +static int zynqmp_nvmem_read(void *context, unsigned int offset,
> > + void *val, size_t bytes)
> > +{
> > + int ret;
> > + int idcode, version;
> > + const struct zynqmp_eemi_ops *eemi_ops =
> zynqmp_pm_get_eemi_ops();
> > +
> > + if (!eemi_ops || !eemi_ops->get_chipid)
> > + return -ENXIO;
> > +
> > + ret = eemi_ops->get_chipid(&idcode, &version);
> > + if (ret < 0)
> > + return ret;
> > +
> > + pr_debug("Read chipid val %x %x\n", idcode, version);
> > + *(int *)val = version & SILICON_REVISION_MASK;
>
> Use dev_dbg here.

Will fix in the next version..

> > +
> > + return 0;
> > +}
> > +
> > +static struct nvmem_config econfig = {
> > + .name = "zynqmp-nvmem",
> > + .owner = THIS_MODULE,
> > + .word_size = 1,
> > + .size = 1,
> > + .read_only = true,
> > +};
> > +
> > +static const struct of_device_id zynqmp_nvmem_match[] = {
> > + { .compatible = "xlnx,zynqmp-nvmem-fw", },
> > + { /* sentinel */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, zynqmp_nvmem_match);
> > +
> > +static int zynqmp_nvmem_probe(struct platform_device *pdev) {
> > + struct nvmem_device *nvmem;
> > +
> > + econfig.dev = &pdev->dev;
> > + econfig.reg_read = zynqmp_nvmem_read;
> > +
> > + nvmem = nvmem_register(&econfig);
> You can use devm_ variant and remove the zynqmp_nvmem_remove() totally
>
Will fix in the next version...

Regards,
Navakishore.
\
 
 \ /
  Last update: 2018-09-17 05:14    [W:0.049 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site