lkml.org 
[lkml]   [2018]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v4 20/20] net: WireGuard secure network tunnel
Hi Jason,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url: https://github.com/0day-ci/linux/commits/Jason-A-Donenfeld/WireGuard-Secure-Network-Tunnel/20180916-043623
config: powerpc-canyonlands_defconfig (attached as .config)
compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc

All warnings (new ones prefixed by >>):

drivers/net/wireguard/send.c: In function 'packet_encrypt_worker':
>> drivers/net/wireguard/send.c:320:1: warning: the frame size of 1136 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^
--
drivers/net/wireguard/receive.c: In function 'packet_decrypt_worker':
>> drivers/net/wireguard/receive.c:520:1: warning: the frame size of 1136 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^

vim +320 drivers/net/wireguard/send.c

294
295 void packet_encrypt_worker(struct work_struct *work)
296 {
297 struct crypt_queue *queue =
298 container_of(work, struct multicore_worker, work)->ptr;
299 struct sk_buff *first, *skb, *next;
300 simd_context_t simd_context = simd_get();
301
302 while ((first = ptr_ring_consume_bh(&queue->ring)) != NULL) {
303 enum packet_state state = PACKET_STATE_CRYPTED;
304
305 skb_walk_null_queue_safe (first, skb, next) {
306 if (likely(skb_encrypt(skb, PACKET_CB(first)->keypair,
307 simd_context)))
308 skb_reset(skb);
309 else {
310 state = PACKET_STATE_DEAD;
311 break;
312 }
313 }
314 queue_enqueue_per_peer(&PACKET_PEER(first)->tx_queue, first,
315 state);
316
317 simd_context = simd_relax(simd_context);
318 }
319 simd_put(simd_context);
> 320 }
321

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-09-16 00:20    [W:0.216 / U:1.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site