lkml.org 
[lkml]   [2018]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4 4/8] usb: dwc3: implement stream transfer timeout
Date
Hi Thinh,

>>
>> @@ -2403,6 +2424,13 @@ static void
>dwc3_gadget_endpoint_transfer_in_progress(struct dwc3_ep *dep,
>> stop = true;
>> }
>>
>> + /*
>> + * Delete the timer that was started in __dwc3_gadget_kick_transfer()
>> + * for stream capable endpoints.
>> + */
>> + if (dep->stream_capable)
>> + del_timer(&dep->stream_timeout_timer);
>> +
>> dwc3_gadget_ep_cleanup_completed_requests(dep, event, status);
>>
>> if (stop) {
>> @@ -2487,6 +2515,11 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,
>> }
>> break;
>> case DWC3_DEPEVT_STREAMEVT:
>> + if (event->status == DEPEVT_STREAMEVT_FOUND)
>> + del_timer(&dep->stream_timeout_timer);
>> + else
>> + dev_dbg(dwc->dev, "unable to find suitable stream");
>
>This debug message is already printed in the driver tracepoint. There's no need to
>print it here. Also, I don't think Felipe will accept adding new dev_dbg() after removing
>all of them and converting them to tracepoints.
>

I agree with you, thanks for correcting. Will remove the debug prints and resend the patches

Thanks,
Anurag Kumar Vulisha

\
 
 \ /
  Last update: 2018-09-15 15:21    [W:0.097 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site