lkml.org 
[lkml]   [2018]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 29/48] perf callchain: Maintain libunwind's address space in map_groups
On Fri, Sep 14, 2018 at 03:15:47PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Sep 13, 2018 at 02:54:31PM +0200, Jiri Olsa escreveu:
> > Currently the address_space was kept in thread struct but it's more
> > appropriate to keep it in map_groups as it's maintained throughout
> > exec's with timestamps. Also we should not flush the address space
> > after exec since it still can be accessed when used with an indexed
> > data file.
> >
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > Link: http://lkml.kernel.org/n/tip-hjryh6x2yfnrz8g0djhez24z@git.kernel.org
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> > tools/perf/util/map.h | 5 ++++-
> > tools/perf/util/thread.h | 1 -
> > tools/perf/util/unwind-libunwind-local.c | 28 ++++++++++++++----------
> > tools/perf/util/unwind-libunwind.c | 9 ++++----
> > tools/perf/util/unwind.h | 7 +++---
> > 5 files changed, 29 insertions(+), 21 deletions(-)
> >
> > diff --git a/tools/perf/util/map.h b/tools/perf/util/map.h
> > index 02c6f6962eb1..b1efe57b8563 100644
> > --- a/tools/perf/util/map.h
> > +++ b/tools/perf/util/map.h
> > @@ -65,10 +65,13 @@ struct maps {
> >
> > struct map_groups {
> > struct maps maps;
> > - struct machine *machine;
> > + struct machine *machine;
> > refcount_t refcnt;
> > u64 timestamp;
> > struct list_head list;
>
> Hey, avoid these distractions, this doesn't change anything and besides

it bothers me.. ;-)

jirka

\
 
 \ /
  Last update: 2018-09-14 21:01    [W:0.074 / U:2.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site