lkml.org 
[lkml]   [2018]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/5] ppoll: use __kernel_timespec
On Sat, Sep 1, 2018 at 10:48 PM Deepa Dinamani <deepa.kernel@gmail.com> wrote:

> +
> + /* We can restart this syscall, usually */
> + if (ret == -EINTR) {
> + restore_user_sigmask(sigmask, &sigsaved);
> + ret = -ERESTARTNOHAND;
> + }

I need a little help understanding this part: In the two existing copies of that
function, you have changed it to

restore_user_sigmask(sigmask, &sigsaved);
if (ret == -EINTR)
ret = -ERESTARTNOHAND;

in the previous patch, but the new new copies you add here do

if (ret == -EINTR) {
restore_user_sigmask(sigmask, &sigsaved);
ret = -ERESTARTNOHAND;
}

Is that intentional, or did you accidently leave a version in here that
you had changed afterwards?

Arnd

\
 
 \ /
  Last update: 2018-09-14 17:58    [W:0.103 / U:4.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site