lkml.org 
[lkml]   [2018]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 23/50] io_edgeport: switch to ->get_serial()
On Thu, Sep 13, 2018 at 03:40:22AM +0100, Al Viro wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> drivers/usb/serial/io_edgeport.c | 37 ++++++++++++++++---------------------
> 1 file changed, 16 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
> index 97c69d373ca6..4ca31c0e4174 100644
> --- a/drivers/usb/serial/io_edgeport.c
> +++ b/drivers/usb/serial/io_edgeport.c

> @@ -1667,17 +1663,12 @@ static int edge_ioctl(struct tty_struct *tty,
> unsigned int cmd, unsigned long arg)
> {
> struct usb_serial_port *port = tty->driver_data;
> - DEFINE_WAIT(wait);

hmm, why was there no gcc warning about this leftover?

> struct edgeport_port *edge_port = usb_get_serial_port_data(port);
>
> switch (cmd) {
> case TIOCSERGETLSR:
> dev_dbg(&port->dev, "%s TIOCSERGETLSR\n", __func__);
> return get_lsr_info(edge_port, (unsigned int __user *) arg);
> -
> - case TIOCGSERIAL:
> - dev_dbg(&port->dev, "%s TIOCGSERIAL\n", __func__);
> - return get_serial_info(edge_port, (struct serial_struct __user *) arg);
> }
> return -ENOIOCTLCMD;
> }

Reviewed-by: Johan Hovold <johan@kernel.org>

\
 
 \ /
  Last update: 2018-09-14 15:58    [W:0.287 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site