lkml.org 
[lkml]   [2018]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] cpufreq: intel_pstate: warn if HWP Native mode and OOB mode are both set
Date
On Sunday, July 29, 2018 6:14:56 AM CEST oceanhe@zoho.com.cn wrote:
> From: Ocean He <hehy1@lenovo.com>
>
> Refer to Intel HWPM Compliance Guide (Document Number: 566474): Bit[6] or
> bit[8] of MSR MISC_PWR_MGMT is set only when BIOS select either HWP Native
> mode or HWP OOB mode. Bit[6] and bit[8] cannot be set both at the same
> time.
>
> Add a warning message if intel_pstate detects both HWP Native mode and
> HWP OOB mode are set at the same time.
>
> Signed-off-by: Ocean He <hehy1@lenovo.com>
> ---
> drivers/cpufreq/intel_pstate.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 3c39712..678d3f2 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2455,8 +2455,12 @@ static bool __init intel_pstate_platform_pwr_mgmt_exists(void)
> id = x86_match_cpu(intel_pstate_cpu_oob_ids);
> if (id) {
> rdmsrl(MSR_MISC_PWR_MGMT, misc_pwr);
> - if ( misc_pwr & (1 << 8))
> + if (misc_pwr & (1 << 8)) {
> + if (misc_pwr & (1 << 6))
> + pr_warn(FW_WARN
> + "HWP Native mode and OOB mode cannot be set both at the same time.\n");
> return true;
> + }
> }
>
> idx = acpi_match_platform_list(plat_info);
>

Srinivas, what do you think about this one?

\
 
 \ /
  Last update: 2018-09-14 11:12    [W:0.249 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site