[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.9 64/78] irda: Only insert new objects into the global database via setsockopt
4.9-stable review patch.  If anyone has any objections, please let me know.


From: Tyler Hicks <>

The irda_setsockopt() function conditionally allocates memory for a new
self->ias_object or, in some cases, reuses the existing
self->ias_object. Existing objects were incorrectly reinserted into the
LM_IAS database which corrupted the doubly linked list used for the
hashbin implementation of the LM_IAS database. When combined with a
memory leak in irda_bind(), this issue could be leveraged to create a
use-after-free vulnerability in the hashbin list. This patch fixes the
issue by only inserting newly allocated objects into the database.


Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Tyler Hicks <>
Reviewed-by: Seth Arnold <>
Reviewed-by: Stefan Bader <>
Signed-off-by: Greg Kroah-Hartman <>
net/irda/af_irda.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

--- a/net/irda/af_irda.c
+++ b/net/irda/af_irda.c
@@ -2023,7 +2023,11 @@ static int irda_setsockopt(struct socket
err = -EINVAL;
goto out;
- irias_insert_object(ias_obj);
+ /* Only insert newly allocated objects */
+ if (free_ias)
+ irias_insert_object(ias_obj);

 \ /
  Last update: 2018-09-13 16:18    [W:0.240 / U:3.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site