lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] power_supply: sysfs: ratelimit property read error message
From
Date
On 09/12/2018 07:48 PM, David Lechner wrote:
> This adds ratelimiting to the message that is printed when reading a
> power supply property via sysfs returns an error. This will prevent
> userspace applications from unintentionally dDOSing the system by
> continuosuly reading a property that returns an error.

s/continuosuly/continuously/

>
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
> drivers/power/supply/power_supply_sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index 6170ed8b6854..dce24f596160 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
> dev_dbg(dev, "driver has no data for `%s' property\n",
> attr->attr.name);
> else if (ret != -ENODEV && ret != -EAGAIN)
> - dev_err(dev, "driver failed to report `%s' property: %zd\n",
> + dev_err_ratelimited(dev,
> + "driver failed to report `%s' property: %zd\n",
> attr->attr.name, ret);
> return ret;
> }
>

\
 
 \ /
  Last update: 2018-09-13 02:51    [W:0.042 / U:4.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site