lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectmutex and rcu list traversal idiosyncrasy
Date
Hi Faisal,


In commit f27b4746f378 ("i40iw: add connection management code") you have in i40iw_add_mqh_6():

rtnl_lock();
for_each_netdev_rcu(...) {
[]
}
rtnl_unlock();

Shouldn't this read:

rtnl_lock();
for_each_netdev(...) {
[]
}
rtnl_unlock();

or

rcu_read_lock();
for_each_netdev_rcu(...) {
[]
}
rcu_read_unlock();


?



Thx, Håkon


\
 
 \ /
  Last update: 2018-09-13 13:56    [W:0.032 / U:4.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site