[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver
Thank you, Andrzej! I was a bit afraid that our patches are a bit too messy and thus ignored 😊
Anyway, this patch (1/5) should be the last one that will cause such chaos in the DRM area.


-----Original Message-----
From: Andrzej Hajda <>
Sent: Thursday, September 13, 2018 12:01
To: Damian Kos <>; David Airlie <>; Rob Herring <>; Mark Rutland <>; Archit Taneja <>; Laurent Pinchart <>; Gustavo Padovan <>; Maarten Lankhorst <>; Sean Paul <>; Sandy Huang <>; Heiko Stübner <>; Quentin Schulz <>;;;;;
Cc: Przemyslaw Gaj <>; Lukasz Tyrala <>; Scott Telford <>; Artur Jedrysek <>; Piotr Sroka <>
Subject: Re: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver


Hi Damian,

Quite late but.

On 28.08.2018 12:24, Damian Kos wrote:
> - Extracted common fields from cdn_dp_device to a new cdns_mhdp_device
> structure which will be used by two separate drivers later on.
> - Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format,
> video_info) from cdn-dp-core.c to cdn-dp-reg.h.
> - Changed prefixes from cdn_dp to cdns_mhdp
> cdn -> cdns to match the other Cadence's drivers
> dp -> mhdp to distinguish it from a "just a DP" as the IP underneath
> this registers map can be a HDMI (which is internally different,
> but the interface for commands, events is pretty much the same).
> - Modified cdn-dp-core.c to use the new driver structure and new function
> names.
> Signed-off-by: Damian Kos <>

Many changes, hard to review. Anyway:

Reviewed-by: Andrzej Hajda <>


 \ /
  Last update: 2018-09-13 12:49    [W:0.060 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site