lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/2] drm: bridge: document bridge attach/detach imbalance
From
Date
On 06.08.2018 08:19, Peter Rosin wrote:
> Since 4a878c03d562 ("drm: bridge: Detach bridge from encoder at encoder
> cleanup time"), it is generally no longer correct to detach bridges from
> encoders manually. Document that.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/gpu/drm/drm_bridge.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index 1638bfe9627c..ba7025041e46 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -104,6 +104,10 @@ EXPORT_SYMBOL(drm_bridge_remove);
> * If non-NULL the previous bridge must be already attached by a call to this
> * function.
> *
> + * Note that bridges attached to encoders are auto-detached during encoder
> + * cleanup in drm_encoder_cleanup(), so drm_bridge_attach() should generally
> + * *not* be balanced with a drm_bridge_detach() in driver code.
> + *
> * RETURNS:
> * Zero on success, error code on failure
> */

Pushed to drm-misc-next.

--
Regards
Andrzej

\
 
 \ /
  Last update: 2018-09-13 11:32    [W:0.081 / U:7.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site