lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 4/9] sched: loadavg: consolidate LOAD_INT, LOAD_FRAC, CALC_LOAD
    On Tue, 28 Aug 2018 13:22:53 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:

    > There are several definitions of those functions/macros in places that
    > mess with fixed-point load averages. Provide an official version.

    missed blk-iolatency.c for some reason?


    --- a/block/blk-iolatency.c~sched-loadavg-consolidate-load_int-load_frac-calc_load-fix
    +++ a/block/blk-iolatency.c
    @@ -139,7 +139,7 @@ struct iolatency_grp {
    #define BLKIOLATENCY_MAX_WIN_SIZE NSEC_PER_SEC
    /*
    * These are the constants used to fake the fixed-point moving average
    - * calculation just like load average. The call to CALC_LOAD folds
    + * calculation just like load average. The call to calc_load() folds
    * (FIXED_1 (2048) - exp_factor) * new_sample into lat_avg. The sampling
    * window size is bucketed to try to approximately calculate average
    * latency such that 1/exp (decay rate) is [1 min, 2.5 min) when windows
    @@ -503,7 +503,7 @@ static void iolatency_check_latencies(st
    lat_info = &parent->child_lat;

    /*
    - * CALC_LOAD takes in a number stored in fixed point representation.
    + * calc_load() takes in a number stored in fixed point representation.
    * Because we are using this for IO time in ns, the values stored
    * are significantly larger than the FIXED_1 denominator (2048).
    * Therefore, rounding errors in the calculation are negligible and
    @@ -512,7 +512,7 @@ static void iolatency_check_latencies(st
    exp_idx = min_t(int, BLKIOLATENCY_NR_EXP_FACTORS - 1,
    div64_u64(iolat->cur_win_nsec,
    BLKIOLATENCY_EXP_BUCKET_SIZE));
    - CALC_LOAD(iolat->lat_avg, iolatency_exp_factors[exp_idx], stat.mean);
    + calc_load(iolat->lat_avg, iolatency_exp_factors[exp_idx], stat.mean);

    /* Everything is ok and we don't need to adjust the scale. */
    if (stat.mean <= iolat->min_lat_nsec &&
    _
    \
     
     \ /
      Last update: 2018-09-13 01:29    [W:2.261 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site