lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 5/7] regulator/mfd: bd718xx: rename bd71837/bd71847 common instances
Hi Matti,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on regulator/for-next]
[also build test ERROR on next-20180913]
[cannot apply to v4.19-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Matti-Vaittinen/regulator-mfd-dt_bindings-bd718x7-Support-ROHM-bd71847/20180914-000129
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: i386-randconfig-s0-201836 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

Note: the linux-review/Matti-Vaittinen/regulator-mfd-dt_bindings-bd718x7-Support-ROHM-bd71847/20180914-000129 HEAD 0df8e57cacf59e85ad40a25fbb1bd7e842608be8 builds fine.
It only hurts bisectibility.

All errors (new ones prefixed by >>):

>> drivers/regulator/bd71837-regulator.c:407:18: error: 'BD718XX_4TH_NODVS_BUCK_VOLTAGE_NUM' undeclared here (not in a function)
.n_voltages = BD718XX_4TH_NODVS_BUCK_VOLTAGE_NUM,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/bd71837-regulator.c:735:18: error: initializer element is not constant
.n_voltages = BD718XX_4TH_NODVS_BUCK_VOLTAGE_NUM,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/bd71837-regulator.c:735:18: note: (near initialization for 'bd71837_regulators[7].desc.n_voltages')

vim +/BD718XX_4TH_NODVS_BUCK_VOLTAGE_NUM +407 drivers/regulator/bd71837-regulator.c

280
281 static const struct bd718xx_regulator_data bd71847_regulators[] = {
282 {
283 .desc = {
284 .name = "buck1",
285 .of_match = of_match_ptr("BUCK1"),
286 .regulators_node = of_match_ptr("regulators"),
287 .id = BD718XX_BUCK1,
288 .ops = &bd718xx_dvs_buck_regulator_ops,
289 .type = REGULATOR_VOLTAGE,
290 .n_voltages = BD718XX_DVS_BUCK_VOLTAGE_NUM,
291 .linear_ranges = bd718xx_dvs_buck_volts,
292 .n_linear_ranges =
293 ARRAY_SIZE(bd718xx_dvs_buck_volts),
294 .vsel_reg = BD718XX_REG_BUCK1_VOLT_RUN,
295 .vsel_mask = DVS_BUCK_RUN_MASK,
296 .enable_reg = BD718XX_REG_BUCK1_CTRL,
297 .enable_mask = BD718XX_BUCK_EN,
298 .owner = THIS_MODULE,
299 },
300 .init = {
301 .reg = BD718XX_REG_BUCK1_CTRL,
302 .mask = BD718XX_BUCK_SEL,
303 .val = BD718XX_BUCK_SEL,
304 },
305 },
306 {
307 .desc = {
308 .name = "buck2",
309 .of_match = of_match_ptr("BUCK2"),
310 .regulators_node = of_match_ptr("regulators"),
311 .id = BD718XX_BUCK2,
312 .ops = &bd718xx_dvs_buck_regulator_ops,
313 .type = REGULATOR_VOLTAGE,
314 .n_voltages = BD718XX_DVS_BUCK_VOLTAGE_NUM,
315 .linear_ranges = bd718xx_dvs_buck_volts,
316 .n_linear_ranges = ARRAY_SIZE(bd718xx_dvs_buck_volts),
317 .vsel_reg = BD718XX_REG_BUCK2_VOLT_RUN,
318 .vsel_mask = DVS_BUCK_RUN_MASK,
319 .enable_reg = BD718XX_REG_BUCK2_CTRL,
320 .enable_mask = BD718XX_BUCK_EN,
321 .owner = THIS_MODULE,
322 },
323 .init = {
324 .reg = BD718XX_REG_BUCK2_CTRL,
325 .mask = BD718XX_BUCK_SEL,
326 .val = BD718XX_BUCK_SEL,
327 },
328 },
329 {
330 .desc = {
331 .name = "buck3",
332 .of_match = of_match_ptr("BUCK3"),
333 .regulators_node = of_match_ptr("regulators"),
334 .id = BD718XX_BUCK3,
335 .ops = &bd718xx_buck_regulator_ops,
336 .type = REGULATOR_VOLTAGE,
337 .n_voltages = BD718XX_1ST_NODVS_BUCK_VOLTAGE_NUM,
338 .linear_ranges = bd718xx_1st_nodvs_buck_volts,
339 .n_linear_ranges =
340 ARRAY_SIZE(bd718xx_1st_nodvs_buck_volts),
341 .vsel_reg = BD718XX_REG_1ST_NODVS_BUCK_VOLT,
342 .vsel_mask = BD718XX_1ST_NODVS_BUCK_MASK,
343 .enable_reg = BD718XX_REG_1ST_NODVS_BUCK_CTRL,
344 .enable_mask = BD718XX_BUCK_EN,
345 .owner = THIS_MODULE,
346 },
347 .init = {
348 .reg = BD718XX_REG_1ST_NODVS_BUCK_CTRL,
349 .mask = BD718XX_BUCK_SEL,
350 .val = BD718XX_BUCK_SEL,
351 },
352 },
353 {
354 .desc = {
355 .name = "buck4",
356 .of_match = of_match_ptr("BUCK4"),
357 .regulators_node = of_match_ptr("regulators"),
358 .id = BD718XX_BUCK4,
359 .ops = &bd718xx_buck_regulator_ops,
360 .type = REGULATOR_VOLTAGE,
361 .n_voltages = BD71847_BUCK4_VOLTAGE_NUM,
362 .linear_ranges = bd71847_buck4_voltage_ranges,
363 .n_linear_ranges =
364 ARRAY_SIZE(bd71847_buck4_voltage_ranges),
365 .enable_reg = BD718XX_REG_2ND_NODVS_BUCK_CTRL,
366 .vsel_reg = BD718XX_REG_2ND_NODVS_BUCK_VOLT,
367 .vsel_mask = BD71847_BUCK4_MASK,
368 .enable_mask = BD718XX_BUCK_EN,
369 .owner = THIS_MODULE,
370 },
371 .init = {
372 .reg = BD718XX_REG_2ND_NODVS_BUCK_CTRL,
373 .mask = BD718XX_BUCK_SEL,
374 .val = BD718XX_BUCK_SEL,
375 },
376 },
377 {
378 .desc = {
379 .name = "buck5",
380 .of_match = of_match_ptr("BUCK5"),
381 .regulators_node = of_match_ptr("regulators"),
382 .id = BD718XX_BUCK5,
383 .ops = &bd718xx_buck_regulator_nolinear_ops,
384 .type = REGULATOR_VOLTAGE,
385 .volt_table = &bd718xx_3rd_nodvs_buck_volts[0],
386 .n_voltages = ARRAY_SIZE(bd718xx_3rd_nodvs_buck_volts),
387 .vsel_reg = BD718XX_REG_3RD_NODVS_BUCK_VOLT,
388 .vsel_mask = BD718XX_3RD_NODVS_BUCK_MASK,
389 .enable_reg = BD718XX_REG_3RD_NODVS_BUCK_CTRL,
390 .enable_mask = BD718XX_BUCK_EN,
391 .owner = THIS_MODULE,
392 },
393 .init = {
394 .reg = BD718XX_REG_3RD_NODVS_BUCK_CTRL,
395 .mask = BD718XX_BUCK_SEL,
396 .val = BD718XX_BUCK_SEL,
397 },
398 },
399 {
400 .desc = {
401 .name = "buck6",
402 .of_match = of_match_ptr("BUCK6"),
403 .regulators_node = of_match_ptr("regulators"),
404 .id = BD718XX_BUCK6,
405 .ops = &bd718xx_buck_regulator_ops,
406 .type = REGULATOR_VOLTAGE,
> 407 .n_voltages = BD718XX_4TH_NODVS_BUCK_VOLTAGE_NUM,
408 .linear_ranges = bd718xx_4th_nodvs_buck_volts,
409 .n_linear_ranges =
410 ARRAY_SIZE(bd718xx_4th_nodvs_buck_volts),
411 .vsel_reg = BD718XX_REG_4TH_NODVS_BUCK_VOLT,
412 .vsel_mask = BD718XX_4TH_NODVS_BUCK_MASK,
413 .enable_reg = BD718XX_REG_4TH_NODVS_BUCK_CTRL,
414 .enable_mask = BD718XX_BUCK_EN,
415 .owner = THIS_MODULE,
416 },
417 .init = {
418 .reg = BD718XX_REG_4TH_NODVS_BUCK_CTRL,
419 .mask = BD718XX_BUCK_SEL,
420 .val = BD718XX_BUCK_SEL,
421 },
422 },
423 {
424 .desc = {
425 .name = "ldo1",
426 .of_match = of_match_ptr("LDO1"),
427 .regulators_node = of_match_ptr("regulators"),
428 .id = BD718XX_LDO1,
429 .ops = &bd718xx_ldo_regulator_ops,
430 .type = REGULATOR_VOLTAGE,
431 .n_voltages = BD718XX_LDO1_VOLTAGE_NUM,
432 .linear_ranges = bd718xx_ldo1_volts,
433 .n_linear_ranges = ARRAY_SIZE(bd718xx_ldo1_volts),
434 .vsel_reg = BD718XX_REG_LDO1_VOLT,
435 .vsel_mask = BD718XX_LDO1_MASK,
436 .enable_reg = BD718XX_REG_LDO1_VOLT,
437 .enable_mask = BD718XX_LDO_EN,
438 .owner = THIS_MODULE,
439 },
440 .init = {
441 .reg = BD718XX_REG_LDO1_VOLT,
442 .mask = BD718XX_LDO_SEL,
443 .val = BD718XX_LDO_SEL,
444 },
445 },
446 {
447 .desc = {
448 .name = "ldo2",
449 .of_match = of_match_ptr("LDO2"),
450 .regulators_node = of_match_ptr("regulators"),
451 .id = BD718XX_LDO2,
452 .ops = &bd718xx_ldo_regulator_nolinear_ops,
453 .type = REGULATOR_VOLTAGE,
454 .volt_table = &ldo_2_volts[0],
455 .vsel_reg = BD718XX_REG_LDO2_VOLT,
456 .vsel_mask = BD718XX_LDO2_MASK,
457 .n_voltages = ARRAY_SIZE(ldo_2_volts),
458 .enable_reg = BD718XX_REG_LDO2_VOLT,
459 .enable_mask = BD718XX_LDO_EN,
460 .owner = THIS_MODULE,
461 },
462 .init = {
463 .reg = BD718XX_REG_LDO2_VOLT,
464 .mask = BD718XX_LDO_SEL,
465 .val = BD718XX_LDO_SEL,
466 },
467 },
468 {
469 .desc = {
470 .name = "ldo3",
471 .of_match = of_match_ptr("LDO3"),
472 .regulators_node = of_match_ptr("regulators"),
473 .id = BD718XX_LDO3,
474 .ops = &bd718xx_ldo_regulator_ops,
475 .type = REGULATOR_VOLTAGE,
476 .n_voltages = BD718XX_LDO3_VOLTAGE_NUM,
477 .linear_ranges = bd718xx_ldo3_volts,
478 .n_linear_ranges = ARRAY_SIZE(bd718xx_ldo3_volts),
479 .vsel_reg = BD718XX_REG_LDO3_VOLT,
480 .vsel_mask = BD718XX_LDO3_MASK,
481 .enable_reg = BD718XX_REG_LDO3_VOLT,
482 .enable_mask = BD718XX_LDO_EN,
483 .owner = THIS_MODULE,
484 },
485 .init = {
486 .reg = BD718XX_REG_LDO3_VOLT,
487 .mask = BD718XX_LDO_SEL,
488 .val = BD718XX_LDO_SEL,
489 },
490 },
491 {
492 .desc = {
493 .name = "ldo4",
494 .of_match = of_match_ptr("LDO4"),
495 .regulators_node = of_match_ptr("regulators"),
496 .id = BD718XX_LDO4,
497 .ops = &bd718xx_ldo_regulator_ops,
498 .type = REGULATOR_VOLTAGE,
499 .n_voltages = BD718XX_LDO4_VOLTAGE_NUM,
500 .linear_ranges = bd718xx_ldo4_volts,
501 .n_linear_ranges = ARRAY_SIZE(bd718xx_ldo4_volts),
502 .vsel_reg = BD718XX_REG_LDO4_VOLT,
503 .vsel_mask = BD718XX_LDO4_MASK,
504 .enable_reg = BD718XX_REG_LDO4_VOLT,
505 .enable_mask = BD718XX_LDO_EN,
506 .owner = THIS_MODULE,
507 },
508 .init = {
509 .reg = BD718XX_REG_LDO4_VOLT,
510 .mask = BD718XX_LDO_SEL,
511 .val = BD718XX_LDO_SEL,
512 },
513 },
514 {
515 .desc = {
516 .name = "ldo5",
517 .of_match = of_match_ptr("LDO5"),
518 .regulators_node = of_match_ptr("regulators"),
519 .id = BD718XX_LDO5,
520 .ops = &bd718xx_ldo_regulator_ops,
521 .type = REGULATOR_VOLTAGE,
522 .n_voltages = BD718XX_LDO5_VOLTAGE_NUM,
523 .linear_ranges = bd718xx_ldo5_volts,
524 .n_linear_ranges = ARRAY_SIZE(bd718xx_ldo5_volts),
525 .vsel_reg = BD718XX_REG_LDO5_VOLT,
526 .vsel_mask = BD71847_LDO5_MASK,
527 .enable_reg = BD718XX_REG_LDO5_VOLT,
528 .enable_mask = BD718XX_LDO_EN,
529 .owner = THIS_MODULE,
530 },
531 .init = {
532 .reg = BD718XX_REG_LDO5_VOLT,
533 .mask = BD718XX_LDO_SEL,
534 .val = BD718XX_LDO_SEL,
535 },
536 },
537 {
538 .desc = {
539 .name = "ldo6",
540 .of_match = of_match_ptr("LDO6"),
541 .regulators_node = of_match_ptr("regulators"),
542 .id = BD718XX_LDO6,
543 .ops = &bd718xx_ldo_regulator_ops,
544 .type = REGULATOR_VOLTAGE,
545 .n_voltages = BD718XX_LDO6_VOLTAGE_NUM,
546 .linear_ranges = bd718xx_ldo6_volts,
547 .n_linear_ranges = ARRAY_SIZE(bd718xx_ldo6_volts),
548 /* LDO6 is supplied by buck5 */
549 .supply_name = "buck5",
550 .vsel_reg = BD718XX_REG_LDO6_VOLT,
551 .vsel_mask = BD718XX_LDO6_MASK,
552 .enable_reg = BD718XX_REG_LDO6_VOLT,
553 .enable_mask = BD718XX_LDO_EN,
554 .owner = THIS_MODULE,
555 },
556 .init = {
557 .reg = BD718XX_REG_LDO6_VOLT,
558 .mask = BD718XX_LDO_SEL,
559 .val = BD718XX_LDO_SEL,
560 },
561 },
562 };
563

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-09-13 22:41    [W:0.067 / U:1.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site