[lkml]   [2018]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] ethernet: hnae: drop adhoc assert() macros
From: Igor Stoppa <>
Date: Sat, 8 Sep 2018 18:01:42 +0300

> Replace assert() with a less misleading test_condition() using WARN()
> Drop one check which had bitrotted and didn't compile anymore.
> Signed-off-by: Igor Stoppa <>

I'm still kind of not happy about this.

Make the driver use kernel interfaces like WARN_ON_ONCE()
etc. directly instead of defining alias CPP macros private to the

If it needs to be conditional upon DEBUG, we have pr_debug() and
the likes as well.

Thank you.

 \ /
  Last update: 2018-09-12 08:08    [W:0.037 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site