lkml.org 
[lkml]   [2018]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bcache: remove unnecessary null poiner check in cache_set_free
On 2018/9/11 8:59, Junhui Tang wrote:
> This patch is NOT OK to me,maybe many cache in a cache_set, and some
> cache are not registered yet, so ca is possible NULL.
Yep, It's my fault. please ingnore the patch.

Thanks,
zhong jiang
> zhong jiang <zhongjiang@huawei.com> 于2018年9月8日周六 下午7:52写道:
>> The iterator in for_each_cache is never null, therefore, remove
>> the redundant null pointer check.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> drivers/md/bcache/super.c | 11 +++++------
>> 1 file changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>> index 94c756c..2d26f9e 100644
>> --- a/drivers/md/bcache/super.c
>> +++ b/drivers/md/bcache/super.c
>> @@ -1513,12 +1513,11 @@ static void cache_set_free(struct closure *cl)
>> bch_btree_cache_free(c);
>> bch_journal_free(c);
>>
>> - for_each_cache(ca, c, i)
>> - if (ca) {
>> - ca->set = NULL;
>> - c->cache[ca->sb.nr_this_dev] = NULL;
>> - kobject_put(&ca->kobj);
>> - }
>> + for_each_cache(ca, c, i) {
>> + ca->set = NULL;
>> + c->cache[ca->sb.nr_this_dev] = NULL;
>> + kobject_put(&ca->kobj);
>> + }
>>
>> bch_bset_sort_state_free(&c->sort);
>> free_pages((unsigned long) c->uuids, ilog2(bucket_pages(c)));
>> --
>> 1.7.12.4
>>
>


\
 
 \ /
  Last update: 2018-09-11 03:37    [W:0.052 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site