lkml.org 
[lkml]   [2018]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 08/16] x86/apic: Add Hygon Dhyana support to APIC
Date
On 2018/9/11 18:14, Borislav Petkov wrote:
>> @@ -1211,9 +1216,11 @@ void __init sync_Arb_IDs(void)
>> {
>> /*
>> * Unsupported on P4 - see Intel Dev. Manual Vol. 3, Ch. 8.6.1 And not
>> - * needed on AMD.
>> + * needed on AMD or Hygon.
>> */
>> - if (modern_apic() || boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
>> + if (modern_apic() ||
>> + boot_cpu_data.x86_vendor == X86_VENDOR_AMD ||
>> + boot_cpu_data.x86_vendor == X86_VENDOR_HYGON)
>
> This change is not needed, after the above hunk in modern_apic(), right?

Yes, you are right. Since the Hygon Dhyana CPU always uses modern APIC,
so the function modern_apic will always return true for Hygon Dhyana.
I will remove this change in next version of patch.

>
> With it removed:
>
> Reviewed-by: Borislav Petkov <bp@suse.de>

--
Regards,
Pu Wen

\
 
 \ /
  Last update: 2018-09-11 15:05    [W:0.068 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site