lkml.org 
[lkml]   [2018]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] sched/topology: SD_ASYM_CPUCAPACITY flag detection
On Mon, Sep 10, 2018 at 10:21:11AM +0200, Ingo Molnar wrote:
>
> * Morten Rasmussen <morten.rasmussen@arm.com> wrote:
>
> > The SD_ASYM_CPUCAPACITY sched_domain flag is supposed to mark the
> > sched_domain in the hierarchy where all cpu capacities are visible for
> > any cpu's point of view on asymmetric cpu capacity systems. The
>
> > /*
> > + * Find the sched_domain_topology_level where all cpu capacities are visible
> > + * for all cpus.
> > + */
>
> > + /*
> > + * Examine topology from all cpu's point of views to detect the lowest
> > + * sched_domain_topology_level where a highest capacity cpu is visible
> > + * to everyone.
> > + */
>
> > #define SD_WAKE_AFFINE 0x0020 /* Wake task to waking CPU */
> > -#define SD_ASYM_CPUCAPACITY 0x0040 /* Groups have different max cpu capacities */
> > +#define SD_ASYM_CPUCAPACITY 0x0040 /* Domain members have different cpu capacities */
>
> For future reference: *please* capitalize 'CPU' and 'CPUs' in future patches like the rest of
> the scheduler does.
>
> You can see it spelled right above the new definition: 'waking CPU' ;-)
>
> (I fixed this up in this patch.)

Noted. Thanks for fixing up the patch.

Morten

\
 
 \ /
  Last update: 2018-09-11 13:05    [W:0.138 / U:19.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site