lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 01/15] staging:rtl8192u: Remove macro eqMacAddr - Style
From
Date
On Wed, 2018-08-08 at 22:00 +0100, John Whitmore wrote:
> The macro eqMacAddr implements the same functionality as the
> ether_addr_equal function defined in etherdevice.h, as a result the
> macro has been removed from the code, and its use replaced with the
> function call.
[]
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
[]
> @@ -4460,15 +4460,15 @@ static void TranslateRxSignalStuff819xUsb(struct sk_buff *skb,
>
> /* Check if the received packet is acceptable. */
> bpacket_match_bssid = (type != IEEE80211_FTYPE_CTL) &&
> - (eqMacAddr(priv->ieee80211->current_network.bssid, (fc & IEEE80211_FCTL_TODS) ? hdr->addr1 : (fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 : hdr->addr3))
> + (ether_addr_equal(priv->ieee80211->current_network.bssid, (fc & IEEE80211_FCTL_TODS) ? hdr->addr1 : (fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 : hdr->addr3))
> && (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV);
> bpacket_toself = bpacket_match_bssid &
> - (eqMacAddr(praddr, priv->ieee80211->dev->dev_addr));
> + (ether_addr_equal(praddr, priv->ieee80211->dev->dev_addr));

Likely this should be

bpacket_match_bssid = bpacket_match_bss &&

as boolean use with a bitwise & is odd.

\
 
 \ /
  Last update: 2018-08-09 00:15    [W:0.064 / U:4.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site