lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging:rtl8712: Style - Removed inline block comment to fix "Statements should start on a tapstop"
From
Date
On 08/08/2018 04:22 AM, Greg KH wrote:
> On Sun, Aug 05, 2018 at 09:41:06PM +0200, Frank Werner-Krippendorf wrote:
>> Removed 5 inline comments "/*volatile*/" rtl87x_event.h, to fix
>> a coding style issue "Statements should start on a tabstop"
>> detected by checkpatch.pl script.
>>
>> Signed-off-by: Frank Werner-Krippendorf <mail@kripp.ch>
>> ---
>> drivers/staging/rtl8712/rtl871x_event.h | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8712/rtl871x_event.h b/drivers/staging/rtl8712/rtl871x_event.h
>> index 5171379..2e59e8e 100644
>> --- a/drivers/staging/rtl8712/rtl871x_event.h
>> +++ b/drivers/staging/rtl8712/rtl871x_event.h
>> @@ -90,13 +90,13 @@ struct event_node {
>> unsigned char *node;
>> unsigned char evt_code;
>> unsigned short evt_sz;
>> - /*volatile*/ int *caller_ff_tail;
>> + int *caller_ff_tail;
>> int caller_ff_sz;
>> };
>>
>> struct c2hevent_queue {
>> - /*volatile*/ int head;
>> - /*volatile*/ int tail;
>
> Those "volatile" seem to imply that something is needed for these
> variables. Please check to ensure that these are ok to remove in that
> there is the proper locking for these types of things.

Those in-line comments are there as a warning that these variables are special.
Just because a tool such as checkpatch says to remove them does not mean that
you should; however, if you want to get rid of the warnings, change the space(s)
after the "*/" into a tab. That silences the checkpatch warning without removing
the implicit warning that these variables are special.

NACK.

Keep in mind that when this driver was submitted, it ran checkpatch cleanly. The
fact that there are now warnings is due to changes in the tool. Following those
will be a never-ending task.

Larry

\
 
 \ /
  Last update: 2018-08-08 18:00    [W:0.073 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site