lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] perf report: Add raw report support for s390 auxiliary trace
Em Wed, Aug 08, 2018 at 12:53:28PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Aug 08, 2018 at 08:39:58AM +0200, Thomas-Mich Richter escreveu:
> > On 08/08/2018 05:37 AM, mpe@ellerman.id.au wrote:
> > > Thomas Richter <tmricht@linux.ibm.com> writes:
> > >> Add support for s390 auxiliary trace support.
> > >> Use 'perf record -e rbd000' to create the perf.data file.
> > >> The event also has the symbolic name SF_CYCLES_BASIC_DIAG,
> > >> using 'perf record -e SF_CYCLES_BASIC_DIAG' is equivalent.
> > > ...
> > >>
> > >> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> > >> Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>
> > >> ---
> > >> tools/perf/util/s390-cpumsf-kernel.h | 71 ++++++++
> > >> tools/perf/util/s390-cpumsf.c | 244 ++++++++++++++++++++++++++-
> > >> 2 files changed, 314 insertions(+), 1 deletion(-)
> > >> create mode 100644 tools/perf/util/s390-cpumsf-kernel.h
> > >
> > >
> > > I'm seeing a build break on ppc64le which seems to be caused by this
> > > commit (I haven't bisected):
> > >
> > > util/s390-cpumsf.c: In function ‘trailer_timestamp’:
> > > util/s390-cpumsf.c:222:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
> > > return *((unsigned long long *) &te->timestamp[te->t]);
> > > ^
> > >
> > >
> > > And on powerpc big endian:
> > > In file included from util/cpumap.h:10:0,
> > > from util/s390-cpumsf.c:150:
> > > util/s390-cpumsf.c: In function ‘s390_cpumsf_basic_show’:
> > > util/s390-cpumsf.c:187:10: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘size_t {aka unsigned int}’ [-Werror=format=]
> > > pr_err("Invalid AUX trace basic entry [%#08lx]\n", pos);
> > > ^
> > >
> > > cheers
> > >
> >
> > Can you please try this patch. Thanks a lot
>
> Ok, this was making the build fail as well on some containers here:

Ok, failed in another container:

11 centos:6 : gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)

CC /tmp/build/perf/tests/sample-parsing.o
cc1: warnings being treated as errors
In file included from util/s390-cpumsf.c:161:
util/s390-cpumsf-kernel.h:16: error: packed attribute is unnecessary for 'def'
util/s390-cpumsf-kernel.h:25: error: packed attribute is unnecessary for 'CL'
util/s390-cpumsf-kernel.h:28: error: packed attribute is unnecessary for 'ia'
util/s390-cpumsf-kernel.h:29: error: packed attribute is unnecessary for 'gpp'
util/s390-cpumsf-kernel.h:30: error: packed attribute is unnecessary for 'hpp'
util/s390-cpumsf-kernel.h:34: error: packed attribute is unnecessary for 'def'
mv: cannot stat `/tmp/build/perf/util/.s390-cpumsf.o.tmp': No such file or directory
make[4]: *** [/tmp/build/perf/util/s390-cpumsf.o] Error 1


For reference, this is the current output of the tests so far, that I'll
let running while I try to figure out this case:

[root@seventh ~]# time dm
1 37.95 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 48.46 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 43.18 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 46.87 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0
5 85.35 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
6 36.86 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
7 41.37 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
8 30.61 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
9 27.69 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
10 26.45 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
11 20.70 centos:6 : FAIL gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
12 39.16 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
13 34.18 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
14 37.12 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
15: debian:9

\
 
 \ /
  Last update: 2018-08-08 18:00    [W:0.070 / U:2.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site