lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] drm/cirrus: flip default from 24bpp to 16bpp
From
Date
On Wed, 2018-08-08 at 13:13 +0200, Gerd Hoffmann wrote:
> The problem with 24bpp is that it is a rather unusual depth these days,

Nit: s/depth/bpp/ here. Depth 24 is very common, it's packing that into
three bytes per pixel that's unusual.

> cirrus is pretty much the only relevant device still using that, and it
> is a endless source of issues. Wayland doesn't support it at all. Bugs
> in Xorg keep showing up.
>
> Typically either 32bpp or 16bpp are used. Using 32bpp would limit the
> resolution to 800x600 due to hardware constrains. So lets go with 16bpp.
>
> Also use the default depth for the framebuffer console and
> mode_info->preferred_depth.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Adam Jackson <ajax@redhat.com>

- ajax

\
 
 \ /
  Last update: 2018-08-08 15:58    [W:0.043 / U:3.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site