lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: trace: track dapm type in snd_soc_dapm_widget
On Wed, 8 Aug 2018 20:39:22 +0800
"Liu, Changcheng" <changcheng.liu@intel.com> wrote:

> > > - TP_printk("widget=%s val=%d", __get_str(name),
> > > - (int)__entry->val)
> > > + TP_printk("widget=%s dapm_id=%d val=%d", __get_str(name),
> > > + (int)__entry->id, (int)__entry->val)
> >
> > Not sure why it was there before, but the (int) typecast isn't needed
> > in either case. __field(int, val) makes __entry->val of type int. Same
> > for id.
> >
> > -- Steve
>
> @Steve: This patch aims at tracking the dapm up/down sequence. For the
> (int) typecast format problem, what do you think of using another
> seperate patch to resolve it?

Yeah, I was just commenting on that as a general comment. It doesn't
affect the actual patch, which I don't see anything wrong with it from
a tracing point of view.

I agree the typecast removal should be done in a separate clean-up
patch.

-- Steve

\
 
 \ /
  Last update: 2018-08-08 14:53    [W:0.035 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site