lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: trace: track dapm type in snd_soc_dapm_widget
On 08:24 Wed 08 Aug, Steven Rostedt wrote:
> On Wed, 8 Aug 2018 17:29:27 +0800
> "Liu, Changcheng" <changcheng.liu@intel.com> wrote:
>
> > Track snd_soc_dapm_widget:id which is used as dapm
> > sequence index in dapm_down_seq/dapm_up_seq. It's
> > useful for checking dapm seq after tracking it.
> >
> > Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
> >
> > diff --git a/include/trace/events/asoc.h b/include/trace/events/asoc.h
> > index 40c300f..0bc935b 100644
> > --- a/include/trace/events/asoc.h
> > +++ b/include/trace/events/asoc.h
> > @@ -92,16 +92,18 @@ DECLARE_EVENT_CLASS(snd_soc_dapm_widget,
> >
> > TP_STRUCT__entry(
> > __string( name, w->name )
> > + __field( int, id )
> > __field( int, val )
> > ),
> >
> > TP_fast_assign(
> > __assign_str(name, w->name);
> > + __entry->id = w->id;
> > __entry->val = val;
> > ),
> >
> > - TP_printk("widget=%s val=%d", __get_str(name),
> > - (int)__entry->val)
> > + TP_printk("widget=%s dapm_id=%d val=%d", __get_str(name),
> > + (int)__entry->id, (int)__entry->val)
>
> Not sure why it was there before, but the (int) typecast isn't needed
> in either case. __field(int, val) makes __entry->val of type int. Same
> for id.
>
> -- Steve

@Steve: This patch aims at tracking the dapm up/down sequence. For the
(int) typecast format problem, what do you think of using another
seperate patch to resolve it?

-- Changcheng
>
> > );
> >
> > DEFINE_EVENT(snd_soc_dapm_widget, snd_soc_dapm_widget_power,
>

\
 
 \ /
  Last update: 2018-08-08 14:41    [W:0.059 / U:4.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site