lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] media: dt: adv7604: Fix slave map documentation
Date
Hi Kieran,

On Wednesday, 8 August 2018 13:23:32 EEST Kieran Bingham wrote:
> Hi Michal,
>
> Thank you for your review.
>
> +Rob, +Mark, +Laurent asking for opinions if anyone has any on prefixes
> through media tree.
>
> On 08/08/18 08:48, Michal Vokáč wrote:
> > On 7.8.2018 17:54, Kieran Bingham wrote:
> > Hi Kieran,
> >
> >> The reg-names property in the documentation is missing an '='. Add it.
> >>
> >> Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend
> >> bindings to allow specifying slave map addresses")
> >
> > "dt-bindings: media: " is preferred for the subject.
>
> This patch will go through the media-tree as far as I am aware, and
> Mauro prefixes all commits through the media tree with "media:" if they
> are not already prefixed.
>
> Thus this would then become "media: dt-bindings: media: adv7604: ...."
> as per my commit: 9feb786876c7 which seems a bit redundant.
>
> Is it still desired ? If so I'll send a V2. (perhaps needed anyway, as I
> seem to have erroneously shortened dt-bindings: to just dt: which wasn't
> intentional.
>
> > I think you should also add device tree maintainers to the recipients.
>
> Added to this mail to ask opinions on patch prefixes above.
>
> Originally, I believed the list was sufficient as this is a trivial
> patch, and it goes through the media tree.
>
> But, it turned out to be more controversial :)
>
> Rob, Mark, should I add you to all patches affecting DT? Or is the list
> sufficient?

Given the insane amount of patches received by DT maintainers, I personally
try to use common sense and only disturb them when needed. Such a typo fix
doesn't qualify for a full CC list in my opinion.

> >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> >> ---
> >> Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> >> b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> >> index dcf57e7c60eb..b3e688b77a38 100644
> >> --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> >> +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> >> @@ -66,7 +66,7 @@ Example:
> >> * other maps will retain their default addresses.
> >> */
> >> reg = <0x4c>, <0x66>;
> >> - reg-names "main", "edid";
> >> + reg-names = "main", "edid";
> >> reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>;
> >> hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;

--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2018-08-08 12:26    [W:0.033 / U:1.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site