lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] mtd: rawnand: vf610_nfc: explicitly disable interrupts first
Hi Stefan,

Stefan Agner <stefan@agner.ch> wrote on Mon, 6 Aug 2018 11:29:08 +0200:

> Explicitly disable all interrupts on probe. This should be the
> default state, but the bootloader could leave the device in any
> state. No issues have been observed so far, but it is still worth
> fixing it.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> drivers/mtd/nand/raw/vf610_nfc.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c
> index 740a91c5c86e..52e7811c0bde 100644
> --- a/drivers/mtd/nand/raw/vf610_nfc.c
> +++ b/drivers/mtd/nand/raw/vf610_nfc.c
> @@ -130,8 +130,13 @@
> #define CONFIG_PAGE_CNT_SHIFT 0
>
> /* NFC_IRQ_STATUS Field */
> +#define WERR_IRQ_BIT BIT(31)
> +#define DONE_IRQ_BIT BIT(30)
> #define IDLE_IRQ_BIT BIT(29)
> +#define WERR_EN_BIT BIT(22)
> +#define DONE_EN_BIT BIT(21)
> #define IDLE_EN_BIT BIT(20)
> +#define WERR_CLEAR_BIT BIT(19)
> #define DONE_CLEAR_BIT BIT(18)
> #define IDLE_CLEAR_BIT BIT(17)
>
> @@ -819,6 +824,10 @@ static int vf610_nfc_probe(struct platform_device *pdev)
>
> init_completion(&nfc->cmd_done);
>
> + vf610_nfc_clear(nfc, NFC_IRQ_STATUS, WERR_EN_BIT);
> + vf610_nfc_clear(nfc, NFC_IRQ_STATUS, DONE_EN_BIT);
> + vf610_nfc_clear(nfc, NFC_IRQ_STATUS, IDLE_EN_BIT);
> +

Why not just one call with:

vf610_nfc_clear(nfc, NFC_IRQ_STATUS, WERR_EN_BIT | DONE_EN_BIT | IDLE_EN_BIT);

The comment applies for the next patch as well.

> err = devm_request_irq(nfc->dev, irq, vf610_nfc_irq, 0, DRV_NAME, mtd);
> if (err) {
> dev_err(nfc->dev, "Error requesting IRQ!\n");

Thanks,
Miquèl

\
 
 \ /
  Last update: 2018-08-08 11:55    [W:0.036 / U:4.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site