lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/17] staging:rtl8192u: Rename cpMacAddr Macro - Style
From
Date
On Tue, 2018-08-07 at 22:12 +0100, John Whitmore wrote:
> Rename the Macro cpMacAddr(des, src), as it causes a checkpatch issue
> due its use of CamelCase naming, to cp_mac_addr(des, src).
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
[]
> @@ -33,7 +33,7 @@ struct rt_dot11d_info {
> #define eq_mac_addr(a, b) (((a)[0] == (b)[0] && \
> (a)[1] == (b)[1] && (a)[2] == (b)[2] && (a)[3] == (b)[3] && \
> (a)[4] == (b)[4] && (a)[5] == (b)[5]) ? 1 : 0)
> -#define cpMacAddr(des, src) ((des)[0] = (src)[0], \
> +#define cp_mac_addr(des, src) ((des)[0] = (src)[0], \
> (des)[1] = (src)[1], (des)[2] = (src)[2], \
> (des)[3] = (src)[3], (des)[4] = (src)[4], \
> (des)[5] = (src)[5])

And this could be ether_addr_copy

\
 
 \ /
  Last update: 2018-08-08 10:15    [W:0.077 / U:15.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site