lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/17] staging:rtl8192u: Rename eqMacAddr macro - Style
From
Date
On Tue, 2018-08-07 at 22:12 +0100, John Whitmore wrote:
> The eqMacAddr(a, b) macro causes a checkpatch issue, due to CamelCase
> naming, so has been renamed to eq_mac_addr(a, b).
>
> This is a coding style change which should not impact on runtime code
> execution.
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
[]
> @@ -30,7 +30,7 @@ struct rt_dot11d_info {
> enum dot11d_state state;
> };
>
> -#define eqMacAddr(a, b) (((a)[0] == (b)[0] && \
> +#define eq_mac_addr(a, b) (((a)[0] == (b)[0] && \
> (a)[1] == (b)[1] && (a)[2] == (b)[2] && (a)[3] == (b)[3] && \
> (a)[4] == (b)[4] && (a)[5] == (b)[5]) ? 1 : 0)

I'd check to see if the etherdevice.h ether_addr_equal
would be used instead of this macro.

\
 
 \ /
  Last update: 2018-08-08 10:13    [W:0.104 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site