[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v2] kbuild: make samples really depend on headers_install
Kernel headers must be installed into $(objtree)/usr/include to avoid
the build failure of samples.

Commit ddea05fa148b ("kbuild: make samples depend on headers_install")
addressed this, but "samples/" is only used for the single target build.

"make samples/" properly installs kernel headers, but it does not work
for general building because a phony target "sample" (no trailing slash)
is used.

Reported-by: David Howells <>
Signed-off-by: Masahiro Yamada <>

Changes in v2:
- Correct commit log (backslash -> slash)
- Fix a typo

Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 7a3c454..1e47d13 100644
--- a/Makefile
+++ b/Makefile
@@ -1009,9 +1009,10 @@ ifdef CONFIG_GDB_SCRIPTS
+$(call if_changed,link-vmlinux)

-# Build samples along the rest of the kernel
+# Build samples along the rest of the kernel. This needs headers_install.
vmlinux-dirs += samples
+samples: headers_install

# The actual objects are generated when descending,
 \ /
  Last update: 2018-08-08 04:16    [W:0.064 / U:1.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site