lkml.org 
[lkml]   [2018]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC PATCH v4 0/2] drm: Add generic colorkey plane properties
Date
Changes in v4:

1) In response to Ville's Syrjälä review comments:

- Added new "colorkey.plane_mask" property that specifies which
planes shall participate in color key matching operation.

- Added short glossary-comment to drm_plane_create_colorkey_properties()
that clarifies 'destination' / 'source' plane terms.

- Returned "colorkey.mask" property that was dropped from v3, looks
like masking is quite common among different HW and hence makes more
sense to have that property by default instead of having additional
color keying modes.

- Changed the color keying mode name to "transparent".

2) In response to Maarten's Lankhorst review comments:

- Added a drm_colorkey_extract_component() helper which is supposed to
commonize color key component value extraction code among DRM drivers.

3) In response to Russell's King review comments:

- The doc-comment to drm_plane_create_colorkey_properties() now
explicitly states that "The converted value shall be *rounded up* to
the nearest value". Hence userspace now knows what to expect when
plane has a 1bpp format.

Please review, thanks.


v3: https://lists.freedesktop.org/archives/dri-devel/2018-June/179057.html
v2: https://lists.freedesktop.org/archives/dri-devel/2018-May/178408.html
v1: https://lists.freedesktop.org/archives/dri-devel/2017-December/160510.html


Dmitry Osipenko (1):
drm/tegra: plane: Add generic colorkey properties for older Tegra's

Laurent Pinchart (1):
drm: Add generic colorkey properties for display planes

drivers/gpu/drm/drm_atomic.c | 20 +++++
drivers/gpu/drm/drm_blend.c | 150 ++++++++++++++++++++++++++++++++
drivers/gpu/drm/tegra/dc.c | 25 ++++++
drivers/gpu/drm/tegra/dc.h | 7 ++
drivers/gpu/drm/tegra/plane.c | 156 ++++++++++++++++++++++++++++++++++
include/drm/drm_blend.h | 3 +
include/drm/drm_plane.h | 91 ++++++++++++++++++++
7 files changed, 452 insertions(+)

--
2.18.0

\
 
 \ /
  Last update: 2018-08-07 20:07    [W:0.067 / U:12.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site