lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 6/6] fsl_pmc: update device bindings
On Mon, 2018-04-16 at 10:13 -0500, Rob Herring wrote:
> On Wed, Apr 11, 2018 at 02:35:51PM +0800, Ran Wang wrote:
> > From: Li Yang <leoli@freescale.com>
>
> Needs a commit msg and the subject should give some indication of what
> the update is. And also start with "dt-bindings: ..."

This patch should also come before the patches that use the new binding.

> > - fsl,mpc8536-pmc: Sleep specifiers consist of three cells, the third of
> > - which will be ORed into PMCDR upon suspend, and cleared from PMCDR
> > - upon resume. The first two cells are as described for fsl,mpc8578-pmc.
> > - This sleep controller only supports disabling devices during system
> > - sleep, or permanently.
> > -
> > - fsl,mpc8548-pmc: Sleep specifiers consist of one or two cells, the
> > - first of which will be ORed into DEVDISR (and the second into
> > - DEVDISR2, if present -- this cell should be zero or absent if the
> > - hardware does not have DEVDISR2) upon a request for permanent device
> > - disabling. This sleep controller does not support configuring devices
> > - to disable during system sleep (unless supported by another compatible
> > - match), or dynamically.
>
> You seem to be breaking backwards compatibility with this change. I
> doubt that is okay on these platforms.

I don't think the sleep specifier stuff ever got used.

-Scott

\
 
 \ /
  Last update: 2018-08-07 02:14    [W:0.065 / U:22.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site