lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] media: uvcvideo: Make some structs const
Date
Hi Joe,

Thank you for the patch.

On Saturday, 4 November 2017 19:23:29 EEST Joe Perches wrote:
> Move some data to text
>
> $ size drivers/media/usb/uvc/uvc_ctrl.o*
> text data bss dec hex filename
> 34323 2364 0 36687 8f4f drivers/media/usb/uvc/
uvc_ctrl.o.new
> 28659 8028 0 36687 8f4f drivers/media/usb/uvc/
uvc_ctrl.o.old
>
> Signed-off-by: Joe Perches <joe@perches.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and taken in my tree.

> ---
> drivers/media/usb/uvc/uvc_ctrl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_ctrl.c
> b/drivers/media/usb/uvc/uvc_ctrl.c index 20397aba6849..44a0554bf62d 100644
> --- a/drivers/media/usb/uvc/uvc_ctrl.c
> +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -37,7 +37,7 @@
> * Controls
> */
>
> -static struct uvc_control_info uvc_ctrls[] = {
> +static const struct uvc_control_info uvc_ctrls[] = {
> {
> .entity = UVC_GUID_UVC_PROCESSING,
> .selector = UVC_PU_BRIGHTNESS_CONTROL,
> @@ -420,7 +420,7 @@ static void uvc_ctrl_set_rel_speed(struct
> uvc_control_mapping *mapping, data[first+1] = min_t(int, abs(value), 0xff);
> }
>
> -static struct uvc_control_mapping uvc_ctrl_mappings[] = {
> +static const struct uvc_control_mapping uvc_ctrl_mappings[] = {
> {
> .id = V4L2_CID_BRIGHTNESS,
> .name = "Brightness",


--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2018-08-07 00:21    [W:0.062 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site