lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] s390/qeth: use true and false for boolean values
From
Date
On 08/05/2018 02:59 AM, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Queued up for net-next, thanks.

> ---
> drivers/s390/net/qeth_l3_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
> index 1833e75..7175086 100644
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -117,9 +117,9 @@ static bool qeth_l3_is_addr_covered_by_ipato(struct qeth_card *card,
> int rc = 0;
>
> if (!card->ipato.enabled)
> - return 0;
> + return false;
> if (addr->type != QETH_IP_TYPE_NORMAL)
> - return 0;
> + return false;
>
> qeth_l3_convert_addr_to_bits((u8 *) &addr->u, addr_bits,
> (addr->proto == QETH_PROT_IPV4)? 4:16);
>

\
 
 \ /
  Last update: 2018-08-06 07:40    [W:0.068 / U:4.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site