[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines
On Mon, 2018-08-06 at 13:58 +1000, Andrew Donnellan wrote:
> If a patch contains a commit reference that happens to span 3 lines, e.g.:
> ===
> With the optimizations for TLB invalidation from commit 0cef77c7798a
> ("powerpc/64s/radix: flush remote CPUs out of single-threaded
> mm_cpumask"), the scope of a TLBI (global vs. local) can now be
> influenced by the value of the 'copros' counter of the memory context.
> ===
> checkpatch will return a GIT_COMMIT_ID error even though the reference
> actually follows the correct format.

The multiple line block code can be difficult to read.

My suggestion is to instead write a subroutine to get the
commit description and compare that against the returned
git commit description.

 \ /
  Last update: 2018-08-06 07:08    [W:0.039 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site