lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] staging/vc04_services: Fix alignment of function arguments
Hi,

On Mon, Aug 6, 2018 at 4:34 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi,
>
> Am 06.08.2018 um 06:07 schrieb Greg Gallagher:
>>
>> Fix warning generated by checkpatch.pl for alignment should match open
>> parenthesis. This is a coding style change only.
>>
>> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
>> ---
>> drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> index ec468d5719b1..33ae8ae8663b 100644
>> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> @@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = {
>> };
>> static int snd_bcm2835_spdif_default_info(struct snd_kcontrol
>> *kcontrol,
>> - struct snd_ctl_elem_info *uinfo)
>> + struct snd_ctl_elem_info *uinfo)
>> {
>> uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
>> uinfo->count = 1;
>
>
> in case this is the only alignment issue in the whole driver, you can have
> my acked-by.
> Otherwise please fix the other ones in the second version.
>
> Btw there are more drivers under vc04_services so a "staging: bcm2835-audio:
> Fix alignment of functions arguments" would be better.
>
> Stefan


I'll fix the other alignment issues as well in the second version and
fix up the subject line to staging: bcm2835-audio.

thanks

Greg

\
 
 \ /
  Last update: 2018-08-06 14:38    [W:0.074 / U:2.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site