lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 11/11] ASoC: wm8994: Mark expected switch fall-through
Date


On 08/06/2018 06:34 AM, Mark Brown wrote:
> On Fri, Aug 03, 2018 at 01:55:18PM -0400, valdis.kletnieks@vt.edu wrote:
>> On Fri, 03 Aug 2018 11:56:12 -0500, "Gustavo A. R. Silva" said:
>>> On 08/03/2018 11:45 AM, Mark Brown wrote:
>>>> Basically nobody ever uses OPCLK so I'd be susprised if anyone ever
>>>> noticed.
>
>> I wonder if nobody uses it because any attempts to do so get an error? :)
>
> No, nobody ever physically wires up an OPCLK. If one was there it'd be
> unavoidable.
>
>>> I see. I wonder what's the best approach in this case. Should that code be
>>> removed instead of 'fixed'?
>
>> I'm thinking that's a spot that needs a 'break;' added.
>
> Yes.
>

OK. I'll send a patch for this. But I wonder what's the best approach in this case,
so the fix can also be applied to stable.

Thanks
--
Gustavo

\
 
 \ /
  Last update: 2018-08-06 13:49    [W:0.076 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site