lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mm/kasan/kasan_init: use true and false for boolean values
Date
Hi Dmitry,

On 08/06/2018 04:04 AM, Dmitry Vyukov wrote:
> On Sun, Aug 5, 2018 at 12:08 AM, Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>> Return statements in functions returning bool should use true or false
>> instead of an integer value.
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Hi Gustavo,
>
> I don't see this code in upstream tree. Is it against some other tree? Which?
>

Yep. It's against linux-next.

Should I use [PATCH next] in the subject next time?

Thanks
--
Gustavo

> Thanks
>
>> ---
>> mm/kasan/kasan_init.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/kasan/kasan_init.c b/mm/kasan/kasan_init.c
>> index 7a2a2f1..c742dc5 100644
>> --- a/mm/kasan/kasan_init.c
>> +++ b/mm/kasan/kasan_init.c
>> @@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd)
>> #else
>> static inline bool kasan_p4d_table(pgd_t pgd)
>> {
>> - return 0;
>> + return false;
>> }
>> #endif
>> #if CONFIG_PGTABLE_LEVELS > 3
>> @@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d)
>> #else
>> static inline bool kasan_pud_table(p4d_t p4d)
>> {
>> - return 0;
>> + return false;
>> }
>> #endif
>> #if CONFIG_PGTABLE_LEVELS > 2
>> @@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud)
>> #else
>> static inline bool kasan_pmd_table(pud_t pud)
>> {
>> - return 0;
>> + return false;
>> }
>> #endif
>> pte_t kasan_zero_pte[PTRS_PER_PTE] __page_aligned_bss;
>> --
>> 2.7.4

\
 
 \ /
  Last update: 2018-08-06 13:40    [W:0.098 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site