lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] usb: host: xhci-plat: Iterate over parent nodes for finding quirks
Date
Hi Mathais,
>>
>>>>
>>>> - if (device_property_read_bool(sysdev, "usb3-lpm-capable"))
>>>> - xhci->quirks |= XHCI_LPM_SUPPORT;
>>>> + if (device_property_read_bool(tmpdev, "usb2-lpm-disable"))
>>>> + xhci->quirks |= XHCI_HW_LPM_DISABLE;
>>>>
>>>> - if (device_property_read_bool(&pdev->dev, "quirk-broken-port-ped"))
>>>> - xhci->quirks |= XHCI_BROKEN_PORT_PED;
>>>> + if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
>>>> + xhci->quirks |= XHCI_LPM_SUPPORT;
>>>>
>>>> - /* imod_interval is the interrupt moderation value in nanoseconds. */
>>>> - xhci->imod_interval = 40000;
>>>
>>> Setting the default imod_interval could be moved before the for()
>>> loop
>>>
>>
>> I thought it would be better if everything related to imod_interval is
>> in one place, so kept it as is. I can fix this in v2 if you suggest.
>
>Default imod_interval needs to be set before the for loop to avoid overwriting a value
>got from device property
>
>So a v2 is needed
>

Thanks for correcting, will fix and send v2

Thanks,
Anurag Kumar Vulisha

>-Mathias
\
 
 \ /
  Last update: 2018-08-06 13:14    [W:0.086 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site