lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/2] perf/hw_breakpoint: Fix breakpoint modify
Date
hi,
Milind reported that modify_user_hw_breakpoint wouldn't
allow the breakpoint changing if the new attr had 'disabled'
set to true.

I found a case where it actualy prevents ptrace user interface
to change the breakpoint. It's described in patch 1 as perf test,
patch 2 is the breakpoint code fix.

I ran strace tests, nothing (new) broken there..

thanks,
jirka


---
Jiri Olsa (2):
perf tests: Add breakpoint modify test
perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set

kernel/events/hw_breakpoint.c | 10 ++++++----
tools/perf/arch/x86/include/arch-tests.h | 1 +
tools/perf/arch/x86/tests/Build | 1 +
tools/perf/arch/x86/tests/arch-tests.c | 6 ++++++
tools/perf/arch/x86/tests/bp-modify.c | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 133 insertions(+), 4 deletions(-)
create mode 100644 tools/perf/arch/x86/tests/bp-modify.c

\
 
 \ /
  Last update: 2018-08-06 12:13    [W:0.136 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site