lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] fs/btrfs/disk-io: Remove unneeded variable "err"
On 2018/8/5 23:27, Joe Perches wrote:
> On Sun, 2018-08-05 at 23:02 +0800, zhong jiang wrote:
>> The err is not used after initalization, So remove it and make
>> the function to be void function.
> []
>> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> []
>> @@ -4193,7 +4192,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
>> if (atomic_read(&delayed_refs->num_entries) == 0) {
>> spin_unlock(&delayed_refs->lock);
>> btrfs_info(fs_info, "delayed_refs has NO entry");
>> - return ret;
> Think a little more about this please.
> This is not a sensible removal.
I am sorry for stupid mistake. I will repost.

Thanks,
zhong jiang
>> }
>>
>> while ((node = rb_first(&delayed_refs->href_root)) != NULL) {
>
> .
>


\
 
 \ /
  Last update: 2018-08-06 04:40    [W:0.050 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site