lkml.org 
[lkml]   [2018]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] Remove uneeded variable "err"
On 2018/8/6 3:14, Nikolay Borisov wrote:
>
> On 5.08.2018 18:02, zhong jiang wrote:
>> zhong jiang (3):
>> fs/btrfs/disk-io: Remove unneeded variable "err"
>> fs/btrfs/extent-tree: remove redudant variable "err"
>> fs/btrfs/tree-log: remove the unneeded variable "err"
>>
>> fs/btrfs/disk-io.c | 12 ++++--------
>> fs/btrfs/extent-tree.c | 6 ++----
>> fs/btrfs/tree-log.c | 5 +----
>> fs/btrfs/tree-log.h | 2 +-
>> 4 files changed, 8 insertions(+), 17 deletions(-)
>>
>
> NAK on the whole series on the basis of using a bulk commit message
> which doesn't really describe the changes of each individual commit. If
> you want those changes to eventually be merged resubmit the series with
> individual reasoning for every commit.
>
>
It's sorry for using a bulk commit message. I will repost with a patch
because it solves the same issue.

Thanks,
zhong jiang

\
 
 \ /
  Last update: 2018-08-06 04:37    [W:0.078 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site