lkml.org 
[lkml]   [2018]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] fs: Convert return type int to vm_fault_t
On Fri, Aug 31, 2018 at 5:03 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Thu, 30 Aug 2018 22:55:47 +0530 Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> > Return type for fault handlers in ext4 and nilfs are
> > changed to use vm_fault_t.
> >
> > Return type of block_page_mkwrite() is changed from
> > int to vm_fault_t. The function signature of
> > block_page_mkwrite() is changed to add one new parameter
> > int *err. This will provide a way for caller functions
> > to get error value along with return value and use it
> > further.
> >
> > Return type of block_page_mkwrite_return() is also changed
> > to use new vm_fault_t type.
> > --- a/fs/nilfs2/file.c
> > +++ b/fs/nilfs2/file.c
> > @@ -51,13 +51,14 @@ int nilfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
> > return err;
> > }
> >
> > -static int nilfs_page_mkwrite(struct vm_fault *vmf)
> > +static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf)
>
> nilfs_page_mkwrite() already has return type vm_fault_t in Linus's
> kernel, due to the now-merged
> fs-nilfs2-adding-new-return-type-vm_fault_t.patch. Looks like a simple
> fix.
>
> I'm beginning to feel vm_fault_t exhaustion. Please remind me what
> benefit we're going to get out of all this churn?

The problem and benefit of these changes was discussed under this mail
thread when the first vm_fault_t patch was posted.

https://marc.info/?l=linux-mm&m=152054772413234&w=4

\
 
 \ /
  Last update: 2018-08-31 08:07    [W:0.084 / U:2.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site