lkml.org 
[lkml]   [2018]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature
On Fri, 3 Aug 2018 11:51:43 +0900 Minchan Kim <minchan@kernel.org> wrote:

> > Is it legitimate to be altering the bdi capabilities at this level? Or
> > is this hacky?
>
> Most of device's bdi capability seems to be static but there are few drivers
> which can change capability. For example, BDI_CAP_STABLE_WRITES
>
> drivers/scsi/iscsi_tcp.c
> drivers/md/raid5.c
>
> I believe it's driver itself advertisement stuff so I hope it's not hack.

The bdi is per-disk (per-queue). So if zram changes the bdi for a
particular partition then it is accidentally mucking with the other
partitions as well, and it shouldn't do that. At least, I think that's
how it works - it's been a while. Jens, wake up ;)

\
 
 \ /
  Last update: 2018-08-04 01:29    [W:0.065 / U:3.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site