lkml.org 
[lkml]   [2018]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC
On Fri, Aug 03, 2018 at 06:10:21PM +0800, kbuild test robot wrote:
> smatch warnings:
> drivers/mfd/rohm-bd718x7.c:163 bd71837_i2c_probe() warn: unsigned 'button.irq' is never less than zero.
>
> 160 button.irq = regmap_irq_get_virq(bd71837->irq_data,
> 161 BD71837_INT_PWRBTN_S);
> 162
> > 163 if (button.irq < 0) {
> 164 dev_err(&i2c->dev, "Failed to get the IRQ\n");
> 165 return button.irq;
> 166 }

Comparing unsiged to smaller-than-zero. These tools are handy! I'll fix
the errno check and send v12 in a minute... (or a bit more - but soonish
in any case =])

Br,
Matti Vaittinen

\
 
 \ /
  Last update: 2018-08-03 13:06    [W:0.037 / U:7.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site