[lkml]   [2018]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ASoC: Convert to using %pOFn instead of
On Tue, Aug 28, 2018 at 4:57 AM Rob Herring <> wrote:

> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.

> + snprintf((char *)dai->platform_name, DAI_NAME_SIZE, "%llx.%pOFn",
> + (unsigned long long) res.start, dma_channel_np);

I understand that is not the part of the change, but wouldn't be good
to replace that ugly casting with proper specifier as well?
I mean
%pa ... &res.start

> + dev_err(&pdev->dev, "%pOFn sync own reference\n",
> + np);

One line?

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2018-08-28 09:58    [W:0.459 / U:4.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site